Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add musl support binary on release #95

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

8Mobius8
Copy link
Contributor

@8Mobius8 8Mobius8 commented Jan 1, 2023

Which issue does this fix?

Closes #93

Describe the solution

Updates release.yml file to include a new asset on release for a binary built with the musl library. This enables direct download and execution on OSs with musl library like alpine.

It should attach the assets template similar to the following:
mask-VERSION-x86_64-unknown-linux-musl.zip

Tested this on my own fork of mask, musl release job can be viewed here:
https://github.com/8Mobius8/mask/actions/runs/3814878606/jobs/6489495643

I additionally tested the binary on the basic alpine image:

$ docker run -it alpine
/ # wget https://github.com/8Mobius8/mask/releases/download/release-test-musl/mask-release-test-musl-x86_64-unknown-linu
x-musl.zip
Connecting to github.com (140.82.114.4:443)
Connecting to objects.githubusercontent.com (185.199.109.133:443)
saving to 'mask-release-test-musl-x86_64-unknown-linux-musl.zip'
mask-release-test-mu 100% |************************************************************************| 1514k  0:00:00 ETA
'mask-release-test-musl-x86_64-unknown-linux-musl.zip' saved
/ # unzip mask-release-test-musl-x86_64-unknown-linux-musl.zip
Archive:  mask-release-test-musl-x86_64-unknown-linux-musl.zip
   creating: mask-release-test-musl-x86_64-unknown-linux-musl/
  inflating: mask-release-test-musl-x86_64-unknown-linux-musl/mask
/ # ./mask-release-test-musl-x86_64-unknown-linux-musl/mask --version
WARNING: no maskfile.md found
mask 0.11.2
/ # file ./mask-release-test-musl-x86_64-unknown-linux-musl/mask
./mask-release-test-musl-x86_64-unknown-linux-musl/mask: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), static-pie linked, BuildID[sha1]=3c5a542679fb31aa65165b983ae33686c66fad36, with debug_info, not stripped

`rustup target` add musl for release flow

Fix rustup command
Copy link
Owner

@jacobdeichert jacobdeichert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I'll try to get a new release out this week.

@jacobdeichert jacobdeichert merged commit ba357ef into jacobdeichert:master Jan 3, 2023
@8Mobius8 8Mobius8 deleted the musl-release-support branch January 3, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for musl
2 participants