Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split parsing logic into separate crate #83

Merged
merged 21 commits into from
Apr 15, 2021
Merged

Split parsing logic into separate crate #83

merged 21 commits into from
Apr 15, 2021

Conversation

jacobdeichert
Copy link
Owner

  • Split parsing logic into separate crate mask-parser
  • Upgrade dependencies
  • Make a new Maskfile struct which is returned from mask_parser::parse
  • Make Maskfile json serializable
  • Make Command.script optional

@jacobdeichert
Split mask parsing logic into separate workspace crate
b12a81b
@jacobdeichert
Fix paths
61d2f6e
@jacobdeichert
Move maskfile with build commands into mask
6c72101
@jacobdeichert
Update tests
a1b65fa
@jacobdeichert
Add test cmd for mask-parser
17f2f9f
@jacobdeichert
Cleanup imports
505b38f
@jacobdeichert
Add test cmd for entire workspace
062e309
@jacobdeichert
Revert back to single root maskfile
7c2c67f
@jacobdeichert
Fix link path
c49b38a
@jacobdeichert
Fix maskfile path in test
641addc
@jacobdeichert
Update deps
03cf6b3
@jacobdeichert
Expose parse method from parser
b0c6eba
@jacobdeichert
Return a Maskfile instead of a root Command
cd654fb 
The root command wasn't really a Command... it was just reusing that struct for simplicity.

Now a full Maskfile definition is returned.
@jacobdeichert
Force colored to output colors in CI environment
88b7c08
@jacobdeichert
Make the Maskfile struct serializable to json
62997ed
@jacobdeichert
Make cmd.script optional
81a02d2 
Parent commands may not have a script, but their subcommands do. Making script optional makes a lot more sense
@jacobdeichert
Prep mask-parser for publishing
0733b48
@jacobdeichert
Remove unnecessary exclusion list
4a7d9a0
@jacobdeichert
Limit to maximum of 5 keywords
1f3c7ed
@jacobdeichert
Remove old mask lib
34ae9a4 
Don't need this anymore now that we have the mask-parser crate published.
@jacobdeichert
Note mask-parser is published
aa9cca9
@jacobdeichert jacobdeichert merged commit 6227bef into master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jacobdeichert