Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow absolute naming for headings #71

Merged
merged 4 commits into from
Aug 10, 2020

Conversation

lsampras
Copy link
Contributor

@lsampras lsampras commented Aug 3, 2020

Which issue does this fix?

Closes #17

Describe the solution

Prune SubCommand names by removing name prefixes that match with parent command name while creating the command tree.

@lsampras lsampras requested a review from jacobdeichert as a code owner August 3, 2020 17:38
Copy link
Owner

@jacobdeichert jacobdeichert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lsampras this looks great! All tests pass so I'm confident it didn't break anything.

I'll add some extra tests on master to verify the new behaviour works.

@jacobdeichert jacobdeichert merged commit 048181e into jacobdeichert:master Aug 10, 2020
@jacobdeichert
Copy link
Owner

I'll release this after I figure out this #64 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support alternative way to define command headings so that ancestor commands are not required to be present
2 participants