Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Homebrew instructions to the readme #63

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

vladimyr
Copy link
Contributor

Which issue does this fix?

Well, this doesn't address any open issue it just expands install instructions. 🤷

Describe the solution

Mask got successfully submitted to Homebrew so I'm just updating readme to add another installation method. 🎉

@vladimyr vladimyr requested a review from jacobdeichert as a code owner June 14, 2020 08:09
Copy link
Owner

@jacobdeichert jacobdeichert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks for doing this! This actually closes #44 :)

I found the formula PR you made. I'm not familiar with creating formulas, but will we need to keep that up to date for each release we make?

@jacobdeichert jacobdeichert merged commit c4d546c into jacobdeichert:master Jun 15, 2020
@vladimyr vladimyr deleted the homebrew branch June 16, 2020 04:05
@vladimyr
Copy link
Contributor Author

I don't know why I assumed there is no such issue 😁

Yup, I'm the one to blame 🙃 It needs to be updated with every release but some nice people converted that to Github action so I did another one: #64 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants