Remove the ON::INIT script idea #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My original goal was to allow each command environment to be able to share some common config/helpers. The on::init script would prepare the environment, however, I ran into some weird issues with zsh not being able to export functions and bash set -a causing subshells invoked by commands (like git stash) to completely fail. I'll need to put some more thought into allowing the easy sharing of common env variables and helpers.
jacobdeichert
changed the title
jacobdeichert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the solution
My original goal was to allow each command environment to be able to share some common config and helpers. The on::init script would prepare the environment, however, I ran into some weird issues with zsh not being able to export functions and bash set -a causing subshells invoked by commands (like git stash) to completely fail.
I'll need to put some more thought into allowing the sharing of common env variables and helpers.
Types of changes