Error when command has no script and missing subcommand #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the problem
When a parent command has no script source but it has subcommands, mask gracefully exited with no warning or error (nothing happened). If a parent command doesn't have a source, it should be required to have a subcommand or else an error should show.
Describe the solution
I used clap's
SubcommandRequiredsetting for the root command and for all subcommands that have no source but have children commands. Clap now shows a proper "missing command" error and a tip to try--help.Also found out about this setting
VersionlessSubcommandswhich I've also enabled. Subcommands don't need a version flag. The root command now is the only command with a version flag.mask --versionHow to test
Types of changes