Allow --version and --help to be used even when missing a maskfile #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, mask was exiting immediately if no maskfile was found. This prevented --version and --help from working unfortuantely. Now mask will try to parse for --help or --version and not show an exit error. This also means it may not be immediately obvious that you are missing a maskfile.
jacobdeichert
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the solution
When missing a
maskfile.md, the process exited with an error which prevented--version, -Vand--help, -hfrom being useful in other directories.Also when a subcommand is missing,
masknow properly exits with an error message and status code 1.How to test
Types of changes
Technically a breaking change because
masknow exits for a missing subcommand.