Add choices list #111
Merged
Add choices list #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set type to "enum" and add a "choices" list. If flag value is not one of the choices, this task will fail.
|
Thanks for the PR! I plan on finding time this week to review 👍 |
|
I find out that we do not really need a |
Only choices list is needed if you want to check flag value.
jacobdeichert
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we add a "choices" list to a
masktask flag, and if flag value is not one of the choices, this task will fail.Which issue does this fix?
This is discussed in issue #91.
I don't add filepath and dirpath in this PR, I think this might need more discussion.
Describe the solution
Before pass arguments to scripts, I check if this flag value shows in the choices list.