Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect links in properties #820

Open
jorgegomzar opened this issue Feb 7, 2024 · 3 comments · May be fixed by #1673
Open

Detect links in properties #820

jorgegomzar opened this issue Feb 7, 2024 · 3 comments · May be fixed by #1673
Labels
enhancement New feature or request

Comments

@jorgegomzar
Copy link

jorgegomzar commented Feb 7, 2024

Is your feature request related to a problem? Please describe.
In my Obsidian notes, I have a lot of links set in the properties as text or lists.

But when serving the same file using Quartz, it does not detect all these links from Obsidian properties -> here

Describe the solution you'd like
If quartz could parse these links from Obsidian properties, the Graph view would display these links as Obsidian does.

Describe alternatives you've considered

  • We can add this as a new property for the Frontmatter transformer
  • We can update the CrawlLinks transformer to parse links from the note's properties.
  • We could add a new transformer that prepends the YAML properties containing links to the beginning of the file. The idea would be to use the already existing CrawLinks transformer to parse these wiki links in right after this transformation. Like this example:
---
title: "title"
up: "[[Home]]"
related:
- "[[related 1]]"
- "[[related 2]]"
- "[[related 3]]"
---
content lorem ipsum...

would become:

---
title: "title"
up: "[[Home]]"
related:
- "[[related 1]]"
- "[[related 2]]"
- "[[related 3]]"
---
- up: [[Home]]
- related: [[related 1]], [[related 2]], [[related 3]]
content lorem ipsum...

Additional context

  • The Markdown note and local graph in my Obsidian vault
imagen
  • The same note served using quartz
imagen
@jorgegomzar jorgegomzar added the enhancement New feature or request label Feb 7, 2024
@jorgegomzar
Copy link
Author

jorgegomzar commented Feb 8, 2024

I tried creating my own transformer to copy all properties with links from the YAML to the Markdown body.
This is how it looks now:
imagen

Will create soon a PR!

@0atman
Copy link

0atman commented Oct 28, 2024

Thanks for the PR @jorgegomzar ! Though it's been closed, it still applies cleanly to my current quartz install, which I'll use until official support is provided. 🎉

@estepankevich
Copy link

estepankevich commented Nov 12, 2024

Thanks a lot @jorgegomzar. Your PR works perfectly for me, I used tags as links in the front matter and your temporary solution worked out of the box !

necauqua added a commit to necauqua/beta-quartz that referenced this issue Dec 24, 2024
I was missing this feature and implemented it, not knowing that there
was jackyzha0#944 already ¯\_(ツ)_/¯

Looking at it now I think that my impl is a little better, and I'd love
to have it upstreamed.

Closes jackyzha0#820 and jackyzha0#944
necauqua added a commit to necauqua/beta-quartz that referenced this issue Dec 24, 2024
I was missing this feature and implemented it, not knowing that there
was jackyzha0#944 already ¯\_(ツ)_/¯

Looking at it now I think that my impl is a little better, and I'd love
to have it upstreamed.

Closes jackyzha0#820 and jackyzha0#944
necauqua added a commit to necauqua/beta-quartz that referenced this issue Dec 24, 2024
I was missing this feature and implemented it, not knowing that there
was jackyzha0#944 already ¯\_(ツ)_/¯

Looking at it now I think that my impl is a little better, and I'd love
to have it upstreamed.

Closes jackyzha0#820 and jackyzha0#944
necauqua added a commit to necauqua/beta-quartz that referenced this issue Dec 24, 2024
I was missing this feature and implemented it, not knowing that there
was jackyzha0#944 already ¯\_(ツ)_/¯

Looking at it now I think that my impl is a little better, and I'd love
to have it upstreamed.

Closes jackyzha0#820 and jackyzha0#944
necauqua added a commit to necauqua/beta-quartz that referenced this issue Dec 24, 2024
I was missing this feature and implemented it, not knowing that there
was jackyzha0#944 already ¯\_(ツ)_/¯

Looking at it now I think that my impl is a little better, and I'd love
to have it upstreamed.

Closes jackyzha0#820 and jackyzha0#944
necauqua added a commit to necauqua/beta-quartz that referenced this issue Dec 24, 2024
I was missing this feature and implemented it, not knowing that there
was jackyzha0#944 already ¯\_(ツ)_/¯

Looking at it now I think that my impl is a little better, and I'd love
to have it upstreamed.

Closes jackyzha0#820 and jackyzha0#944
necauqua added a commit to necauqua/beta-quartz that referenced this issue Jan 2, 2025
I was missing this feature and implemented it, not knowing that there
was jackyzha0#944 already ¯\_(ツ)_/¯

Looking at it now I think that my impl is a little better, and I'd love
to have it upstreamed.

Closes jackyzha0#820 and jackyzha0#944
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants