LabelFilter: proactively best-effort filter querries to downstreams #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksontj
force-pushed
the
issue_558
branch
3 times, most recently
from
803bed1
to
a96a105
Compare
This set of labels is specifically excluded from the list we get from downstream.
jacksontj
changed the title
Today the CreateAndStart method starts the listener in a goroutine async. This is not a problem for regular operations, but during testing this creates a race condition. This changes the behavior so that listen will for-sure be started when the method returns and the hanlder will be in a background goroutine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an implementation for #558
TODO: