Fixing non compliant divider in country dropdown #1485
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Divider li in the country dropdown, between "preferred" countries and the rest of the list, uses the: role='separator' attribute/value. This does not comply with the aria a11y standards, as separators are not allowed in listboxes. I've removed the role, and made the divider aria-hidden='true', to remove it from the a11y tree, since there isn't a particularly good way to implement it that is compliant with a11y standards.