Merge pull request snipe#15631 from snipe/test/importer-tests

Add importer tests

app/Models/Asset.php

@@ -43,16 +43,16 @@ class Asset extends Depreciable
 
     /**
      * Run after the checkout acceptance was declined by the user
-     * 
+     *
      * @param  User   $acceptedBy
      * @param  string $signature
-     */ 
+     */
     public function declinedCheckout(User $declinedBy, $signature)
     {
       $this->assigned_to = null;
       $this->assigned_type = null;
-      $this->accepted = null;      
-      $this->save();        
+      $this->accepted = null;
+      $this->save();
     }
 
     /**
@@ -368,7 +368,7 @@ public function checkOut($target, $admin = null, $checkout_at = null, $expected_
         if ($this->save()) {
             if (is_int($admin)) {
                 $checkedOutBy = User::findOrFail($admin);
-            } elseif (get_class($admin) === \App\Models\User::class) {
+            } elseif ($admin && get_class($admin) === \App\Models\User::class) {
                 $checkedOutBy = $admin;
             } else {
                 $checkedOutBy = auth()->user();
@@ -1705,7 +1705,7 @@ public function scopeByFilter($query, $filter)
                         });
                     });
                 }
-            
+
 
             /**
              * THIS CLUNKY BIT IS VERY IMPORTANT
@@ -1726,7 +1726,7 @@ public function scopeByFilter($query, $filter)
              * assets.location would fail, as that field doesn't exist -- plus we're already searching
              * against those relationships earlier in this method.
              *
-             * - snipe 
+             * - snipe
              *
              */
 

app/Models/Import.php

@@ -2,10 +2,13 @@
 
 namespace App\Models;
 
+use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Database\Eloquent\Model;
 
 class Import extends Model
 {
+    use HasFactory;
+
     protected $casts = [
         'header_row' => 'array',
         'first_row' => 'array',

database/factories/ImportFactory.php

@@ -0,0 +1,146 @@
+<?php
+
+namespace Database\Factories;
+
+use App\Models\Import;
+use Illuminate\Support\Str;
+use Illuminate\Database\Eloquent\Factories\Factory;
+use Tests\Support\Importing;
+
+/**
+ * @extends Factory<Import>
+ */
+class ImportFactory extends Factory
+{
+    /**
+     * @inheritdoc
+     */
+    protected $model = Import::class;
+
+    /**
+     * @inheritdoc
+     */
+    public function definition()
+    {
+        return [
+            'name'     => $this->faker->company,
+            'file_path' => Str::random().'.csv',
+            'filesize'  => $this->faker->randomDigitNotNull(),
+            'field_map' => null,
+        ];
+    }
+
+    /**
+     * Create an accessory import type.
+     *
+     * @return static
+     */
+    public function accessory()
+    {
+        return $this->state(function (array $attributes) {
+            $fileBuilder = Importing\AccessoriesImportFileBuilder::new();
+
+            $attributes['name'] = "{$attributes['name']} Accessories";
+            $attributes['import_type'] = 'accessory';
+            $attributes['header_row'] = $fileBuilder->toCsv()[0];
+            $attributes['first_row'] = $fileBuilder->firstRow();
+
+            return $attributes;
+        });
+    }
+
+    /**
+     * Create an asset import type.
+     *
+     * @return static
+     */
+    public function asset()
+    {
+        return $this->state(function (array $attributes) {
+            $fileBuilder = Importing\AssetsImportFileBuilder::new();
+
+            $attributes['name'] = "{$attributes['name']} Assets";
+            $attributes['import_type'] = 'asset';
+            $attributes['header_row'] = $fileBuilder->toCsv()[0];
+            $attributes['first_row'] = $fileBuilder->firstRow();
+
+            return $attributes;
+        });
+    }
+
+    /**
+     * Create a component import type.
+     *
+     * @return static
+     */
+    public function component()
+    {
+        return $this->state(function (array $attributes) {
+            $fileBuilder = Importing\ComponentsImportFileBuilder::new();
+
+            $attributes['name'] = "{$attributes['name']} Components";
+            $attributes['import_type'] = 'component';
+            $attributes['header_row'] = $fileBuilder->toCsv()[0];
+            $attributes['first_row'] = $fileBuilder->firstRow();
+
+            return $attributes;
+        });
+    }
+
+    /**
+     * Create a consumable import type.
+     *
+     * @return static
+     */
+    public function consumable()
+    {
+        return $this->state(function (array $attributes) {
+            $fileBuilder = Importing\ConsumablesImportFileBuilder::new();
+
+            $attributes['name'] = "{$attributes['name']} Consumables";
+            $attributes['import_type'] = 'consumable';
+            $attributes['header_row'] = $fileBuilder->toCsv()[0];
+            $attributes['first_row'] = $fileBuilder->firstRow();
+
+            return $attributes;
+        });
+    }
+
+     /**
+     * Create a license import type.
+     *
+     * @return static
+     */
+    public function license()
+    {
+        return $this->state(function (array $attributes) {
+            $fileBuilder = Importing\LicensesImportFileBuilder::new();
+
+            $attributes['name'] = "{$attributes['name']} Licenses";
+            $attributes['import_type'] = 'license';
+            $attributes['header_row'] = $fileBuilder->toCsv()[0];
+            $attributes['first_row'] = $fileBuilder->firstRow();
+
+            return $attributes;
+        });
+    }
+
+    /**
+     * Create a users import type.
+     *
+     * @return static
+     */
+    public function users()
+    {
+        return $this->state(function (array $attributes) {
+            $fileBuilder = Importing\UsersImportFileBuilder::new();
+
+            $attributes['name'] = "{$attributes['name']} Employees";
+            $attributes['import_type'] = 'user';
+            $attributes['header_row'] = $fileBuilder->toCsv()[0];
+            $attributes['first_row'] = $fileBuilder->firstRow();
+
+            return $attributes;
+        });
+    }
+}

database/factories/UserFactory.php

@@ -7,6 +7,9 @@
 use Illuminate\Database\Eloquent\Factories\Factory;
 use \Auth;
 
+/**
+ * @extends Factory<User>
+ */
 class UserFactory extends Factory
 {
     /**

tests/Feature/Importing/Api/GeneralImportTest.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace Tests\Feature\Importing\Api;
+
+use App\Models\User;
+
+class GeneralImportTest extends ImportDataTestCase
+{
+    public function testRequiresExistingImport()
+    {
+        $this->actingAsForApi(User::factory()->canImport()->create());
+
+        $this->importFileResponse(['import' => 9999, 'import-type' => 'accessory'])
+            ->assertStatusMessageIs('import-errors');
+    }
+}