Automated Resyntax fixes #584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
This is an automated change generated by Resyntax. #### Pass 1 Applied 1 fix to [`collection/private/testing/literal-mutable-red-black-tree.rkt`](../blob/HEAD/collection/private/testing/literal-mutable-red-black-tree.rkt) * Line 35, `define-simple-macro-to-define-syntax-parse-rule`: The `define-simple-macro` form has been renamed to `define-syntax-parse-rule`. Applied 3 fixes to [`collection/association-list.rkt`](../blob/HEAD/collection/association-list.rkt) * Line 8, `predicate/c-migration`: The `predicate/c` contract is less clear than a `->` contract and no longer improves performance. * Line 25, `predicate/c-migration`: The `predicate/c` contract is less clear than a `->` contract and no longer improves performance. * Line 26, `predicate/c-migration`: The `predicate/c` contract is less clear than a `->` contract and no longer improves performance. Applied 1 fix to [`type/record/private/definition-macro.rkt`](../blob/HEAD/type/record/private/definition-macro.rkt) * Line 42, `define-simple-macro-to-define-syntax-parse-rule`: The `define-simple-macro` form has been renamed to `define-syntax-parse-rule`. Applied 1 fix to [`collection/private/testing/mutable-red-black-tree-invariants.rkt`](../blob/HEAD/collection/private/testing/mutable-red-black-tree-invariants.rkt) * Line 11, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 2 fixes to [`collection/record.rkt`](../blob/HEAD/collection/record.rkt) * Line 10, `predicate/c-migration`: The `predicate/c` contract is less clear than a `->` contract and no longer improves performance. * Line 21, `predicate/c-migration`: The `predicate/c` contract is less clear than a `->` contract and no longer improves performance. Applied 1 fix to [`collection/multiset.rkt`](../blob/HEAD/collection/multiset.rkt) * Line 34, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 3 fixes to [`collection/set.rkt`](../blob/HEAD/collection/set.rkt) * Line 8, `predicate/c-migration`: The `predicate/c` contract is less clear than a `->` contract and no longer improves performance. * Line 9, `predicate/c-migration`: The `predicate/c` contract is less clear than a `->` contract and no longer improves performance. * Line 10, `predicate/c-migration`: The `predicate/c` contract is less clear than a `->` contract and no longer improves performance. Applied 4 fixes to [`collection/entry.rkt`](../blob/HEAD/collection/entry.rkt) * Line 20, `predicate/c-migration`: The `predicate/c` contract is less clear than a `->` contract and no longer improves performance. * Line 21, `predicate/c-migration`: The `predicate/c` contract is less clear than a `->` contract and no longer improves performance. * Line 90, `single-clause-match-to-match-define`: This `match` expression can be simplified using `match-define`. * Line 94, `single-clause-match-to-match-define`: This `match` expression can be simplified using `match-define`. Applied 2 fixes to [`collection/table.rkt`](../blob/HEAD/collection/table.rkt) * Line 21, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 91, `define-simple-macro-to-define-syntax-parse-rule`: The `define-simple-macro` form has been renamed to `define-syntax-parse-rule`. Applied 2 fixes to [`collection/range-set.rkt`](../blob/HEAD/collection/range-set.rkt) * Line 49, `predicate/c-migration`: The `predicate/c` contract is less clear than a `->` contract and no longer improves performance. * Line 50, `predicate/c-migration`: The `predicate/c` contract is less clear than a `->` contract and no longer improves performance. ## Summary Fixed 20 issues in 10 files. * Fixed 12 occurrences of `predicate/c-migration` * Fixed 3 occurrences of `define-simple-macro-to-define-syntax-parse-rule` * Fixed 3 occurrences of `tidy-require` * Fixed 2 occurrences of `single-clause-match-to-match-define`
jackfirth
reviewed
Oct 8, 2024
Comment on lines
+97
to
+102
| #:fail-when (findf (λ (row-stx) (> (length (syntax->list row-stx)) (add1 num-columns))) | ||
| row-stxs) (format "too many values in row, table has only ~v columns" | ||
| num-columns) | ||
| #:fail-when (findf (λ (row-stx) (< (length (syntax->list row-stx)) (add1 num-columns))) | ||
| row-stxs) (format "not enough values in row, table expects ~v columns" | ||
| num-columns) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated change generated by Resyntax.
Pass 1
Applied 1 fix to
collection/private/testing/literal-mutable-red-black-tree.rktdefine-simple-macro-to-define-syntax-parse-rule: Thedefine-simple-macroform has been renamed todefine-syntax-parse-rule.Applied 3 fixes to
collection/association-list.rktpredicate/c-migration: Thepredicate/ccontract is less clear than a->contract and no longer improves performance.predicate/c-migration: Thepredicate/ccontract is less clear than a->contract and no longer improves performance.predicate/c-migration: Thepredicate/ccontract is less clear than a->contract and no longer improves performance.Applied 1 fix to
type/record/private/definition-macro.rktdefine-simple-macro-to-define-syntax-parse-rule: Thedefine-simple-macroform has been renamed todefine-syntax-parse-rule.Applied 1 fix to
collection/private/testing/mutable-red-black-tree-invariants.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 2 fixes to
collection/record.rktpredicate/c-migration: Thepredicate/ccontract is less clear than a->contract and no longer improves performance.predicate/c-migration: Thepredicate/ccontract is less clear than a->contract and no longer improves performance.Applied 1 fix to
collection/multiset.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 3 fixes to
collection/set.rktpredicate/c-migration: Thepredicate/ccontract is less clear than a->contract and no longer improves performance.predicate/c-migration: Thepredicate/ccontract is less clear than a->contract and no longer improves performance.predicate/c-migration: Thepredicate/ccontract is less clear than a->contract and no longer improves performance.Applied 4 fixes to
collection/entry.rktpredicate/c-migration: Thepredicate/ccontract is less clear than a->contract and no longer improves performance.predicate/c-migration: Thepredicate/ccontract is less clear than a->contract and no longer improves performance.single-clause-match-to-match-define: Thismatchexpression can be simplified usingmatch-define.single-clause-match-to-match-define: Thismatchexpression can be simplified usingmatch-define.Applied 2 fixes to
collection/table.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.define-simple-macro-to-define-syntax-parse-rule: Thedefine-simple-macroform has been renamed todefine-syntax-parse-rule.Applied 2 fixes to
collection/range-set.rktpredicate/c-migration: Thepredicate/ccontract is less clear than a->contract and no longer improves performance.predicate/c-migration: Thepredicate/ccontract is less clear than a->contract and no longer improves performance.Summary
Fixed 20 issues in 10 files.
predicate/c-migrationdefine-simple-macro-to-define-syntax-parse-ruletidy-requiresingle-clause-match-to-match-define