Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(README): declare code fences as JS, ++readability #71

Merged
merged 4 commits into from
May 4, 2024

Conversation

msimerson
Copy link
Contributor

@msimerson msimerson commented Apr 29, 2024

After

Screenshot 2024-04-29 at 11 25 18 AM
Screenshot 2024-04-29 at 11 25 25 AM

Before

Screenshot 2024-04-29 at 11 26 18 AM

@msimerson msimerson marked this pull request as ready for review April 29, 2024 18:27
@jackbearheart
Copy link
Owner

@msimerson Thanks for the help with the build. I'll leave this open until it passes. Maybe the new node-gyp will work, maybe we have to use a version of libxmljs for which there is a binary available, or maybe skip/ignore because this is not a relevant failure.

@msimerson
Copy link
Contributor Author

Yeah, all the failures are because of libxmljs failing to build. Probably a sensible thing to do is just convert that XML to a JS or JSON file. That'll also speed up the testing.

@jackbearheart jackbearheart merged commit 5a49439 into jackbearheart:master May 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants