-
-
Notifications
You must be signed in to change notification settings - Fork 32
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
811dddf
commit 7e574ab
Showing
2 changed files
with
18 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7e574ab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jacebrowning
in
shell.rm()
you should keep
if os.path.exists(path):
at least for windows.Because
rmdir /Q /S
throw an error of path does not exist7e574ab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jacebrowning
Ok so you pick code piece by piece. And try to fix some things or arrange some things at the same time.
I was thinking you will pick several bag of commits as is.
Are you really sure you dont want juste merge the PR, and fix after that the one or two things that you dislike ? There is a lot of chance that you will re-do the bug I have fixed while I was working on this PR and windows support.
Just merge the PR, and change things after :)