Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MaskGroup recursive_drop docstring claims inplace operation #123

Closed
jacanchaplais opened this issue Apr 3, 2023 · 0 comments
Closed

MaskGroup recursive_drop docstring claims inplace operation #123

jacanchaplais opened this issue Apr 3, 2023 · 0 comments
Assignees
@jacanchaplais
Labels
documentation Improvements or additions to documentation
Milestone
0.2.13

Comments

@jacanchaplais
Copy link
Owner

jacanchaplais commented Apr 3, 2023 •
edited
Loading

Minor mistake in docstring, claiming MaskGroup.recursive_drop() is an inplace method. This is set by a parameter, so that should be removed.

See https://graphicle.readthedocs.io/en/0.2.10/api/graphicle.data.MaskGroup.recursive_drop.html
@jacanchaplais jacanchaplais added the documentation Improvements or additions to documentation label Apr 3, 2023
@jacanchaplais jacanchaplais self-assigned this Apr 3, 2023
jacanchaplais added a commit that referenced this issue May 31, 2023
@jacanchaplais
rm docstring error claiming method inplace by default #123
4d693d9
@jacanchaplais jacanchaplais added this to the 0.2.13 milestone May 31, 2023
jacanchaplais added a commit that referenced this issue May 31, 2023
@jacanchaplais
Merge pull request #133 from jacanchaplais/patch/recusrive-doc-123
0c51a69 
Docstring correction #123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacanchaplais jacanchaplais

Labels
documentation Improvements or additions to documentation
Projects
graphicle
Status: Done
Milestone
0.2.13
Development

No branches or pull requests
1 participant
@jacanchaplais