Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found your package and functionality quite useful. It would be much easier to use if there were an associated
predict
method. This would allow calculating cut points on some dataset and then applying these cuts/featurization to new data.I went ahead and implemented this. In the process, I needed to create some S3 methods.
Because of a change in roxygen2 behavior, I had to make other changes to the documentation code. I tried to commit in logical way to separate this. Also, there were some end of line spaces. Rstudio and atom both clear these, so I committed this separately as well.
Let me know what you think.