Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to selenium 3.14 #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrade to selenium 3.14 #5

wants to merge 2 commits into from

Conversation

rkieft
Copy link

@rkieft rkieft commented May 21, 2019

Hi,
I changed your code so it will now work with Selenium 3.14.
It now uses the proxy.getProxyStatus(); instead of proxy.getStatus(); which was deprecated since Selenium 3.10.
So I believe my changes will be backwards compatible untill version 3.10 of Selenium.

I also changed the browsername to not contain any spaces anymore.
By doing so it is easier to use an absolute json path in Jenkins for example.

Best Regards,

Richard

Richard Kieft added 2 commits May 21, 2019 17:04
Fixed usage of deprecated stuff
removed unused exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant