Fixed bug: wrong lang #471
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jodacame, thank you for your contribution! Unfortunately, I cannot accept your PR in its current state. We will first require some test cases that clearly show the desired behaviour. Please add such test cases to your PR. Plus, all the formatting changes make the diff difficult to read. Please make sure that your PR does not change formatting of any existing code, and fits to the rest of the code. I will happily review this PR once
If you have suggestions for improving the code formatting in this repository, I will happily discuss them. But please open a separate PR for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#194 Silent error added