improve memory leak

jBernavaPrah · Jun 5, 2022 · 686d4b6 · 686d4b6
1 parent e51a54f
commit 686d4b6
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 15 deletions.
diff --git a/src/Errors/ValidationError.php b/src/Errors/ValidationError.php
@@ -18,7 +18,7 @@ class ValidationError extends Error
 
     public static function definition(): string
     {
-        $codes = implode("\n\n", app(GenerateValidationCodeEnum::class)->generate());
+       $codes = implode("\n\n", app(GenerateValidationCodeEnum::class)->generate());
 
         return /** @lang GraphQL */ <<<GRAPHQL
 

diff --git a/src/GenerateValidationCodeEnum.php b/src/GenerateValidationCodeEnum.php
@@ -11,33 +11,38 @@
 
 class GenerateValidationCodeEnum
 {
+
+    protected array $codes = [];
+
     /**
      * @return array
      */
     public function generate(): array
     {
-        $codes = [];
-        foreach ((new ReflectionClass(Validator::class))->getMethods() as $reflectionMethod) {
-            if (
-                $reflectionMethod->getShortName() === "validated" ||
-                ! Str::of($reflectionMethod->getShortName())->startsWith('validate') ||
-                !($code = $this->validationCodeString($reflectionMethod->getShortName()))
-            ) {
-                continue;
-            }
-
-            $description = (new PhpdocParser(new TagSet([new Summery()])))->parse($reflectionMethod->getDocComment())['description'];
 
-
-            $codes[] = <<<GRAPHQL
+        if (!$this->codes) {
+            foreach ((new ReflectionClass(Validator::class))->getMethods() as $reflectionMethod) {
+                if (
+                    $reflectionMethod->getShortName() === "validated" ||
+                    !Str::of($reflectionMethod->getShortName())->startsWith('validate') ||
+                    !($code = $this->validationCodeString($reflectionMethod->getShortName()))
+                ) {
+                    continue;
+                }
+
+                $description = (new PhpdocParser(new TagSet([new Summery()])))->parse($reflectionMethod->getDocComment())['description'];
+                $this->codes[] = <<<GRAPHQL
 """
 $description
 """
 $code
 GRAPHQL;
+            }
+
         }
 
-        return $codes;
+
+        return $this->codes;
     }
 
     /**