Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escaping quotes symbols in "_quote_identifier_part" #74

Closed
msangel opened this issue Nov 17, 2012 · 1 comment
Closed

escaping quotes symbols in "_quote_identifier_part" #74

msangel opened this issue Nov 17, 2012 · 1 comment
Assignees
Milestone

Comments

@msangel
Copy link

msangel commented Nov 17, 2012

Method "_quote_identifier_part" do basic escaping - it just wrap raw string by extra quote symbols in end and begining:
return $quote_character . $part . $quote_character;

this code can be broken by string , that already contain $quote_character inside.

Simplest solution will be - just dublicating $quote_character inside of string. In that case we will have valid syntax.

For more details see example with "Hello" on: http://dev.mysql.com/doc/refman/5.1/en/string-literals.html

This tested and work with mySql, but other databeses probably have same behavior.

@treffynnon
Copy link
Collaborator

Thanks for the enhancement request. Fixed in commit 314caf8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants