Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing copy #107

Merged
merged 4 commits into from
Aug 6, 2020
Merged

Fix missing copy #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e22dd96
Added a copy files to after install hook
HarelM Jul 23, 2020
a47f397
Fix async call
HarelM Jul 23, 2020
7d6fa27
Change code sign indentity and style
HarelM Jul 26, 2020
bb167ed
Fix missing quotes
HarelM Jul 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions hooks/iosAddTarget.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,10 @@ function parsePbxProject(context, pbxProjectPath) {

function forEachShareExtensionFile(context, callback) {
var shareExtensionFolder = path.join(iosFolder(context), 'ShareExtension');
if (!fs.existsSync(shareExtensionFolder)) {
console.error('!! Shared extension files have not been copied yet!!');
return;
}
fs.readdirSync(shareExtensionFolder).forEach(function(name) {
// Ignore junk files like .DS_Store
if (!/^\..*/.test(name)) {
Expand Down Expand Up @@ -316,6 +320,8 @@ module.exports = function (context) {
if (productName.indexOf('ShareExt') >= 0) {
buildSettingsObj['PROVISIONING_PROFILE'] = PROVISIONING_PROFILE;
buildSettingsObj['DEVELOPMENT_TEAM'] = DEVELOPMENT_TEAM;
buildSettingsObj['CODE_SIGN_STYLE'] = 'Manual';
buildSettingsObj['CODE_SIGN_IDENTITY'] = '"iPhone Distribution"';
j3k0 marked this conversation as resolved.
Show resolved Hide resolved
console.log('Added signing identities for extension!');
}
}
Expand Down
1 change: 1 addition & 0 deletions plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ SOFTWARE.
</config-file>

<hook type="before_plugin_install" src="hooks/npmInstall.js" />
<hook type="after_plugin_install" src="hooks/iosCopyShareExtension.js" />
<hook type="before_prepare" src="hooks/iosCopyShareExtension.js" />
<hook type="after_prepare" src="hooks/iosAddTarget.js" />
<hook type="before_plugin_uninstall" src="hooks/iosRemoveTarget.js" />
Expand Down