-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some devDependencies should be full-fledged dependencies ? #8
Comments
There's a PR that I think fixes this. |
Also I found that the
After that PR then |
closed by #9 |
Sweet, thanks! Any idea when you'll release v0.3.4 (that has this fix) to npmjs.com? |
v0.3.4 is released on https://www.npmjs.com/package/mdx-prism |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi! Thanks for this library. I'm using it in my personal website and this is quite helpful.
I'm not a NPM/js/etc expert, but I believe that many of the
devDependencies
you have listed inpackage.json
should actually bedependencies
, since you use them inindex.js
. I discovered this when I recently added thedepcheck
package to my website as a linting check, and it told me that I wasn't using therehype
package that I had listed as one of my dev dependencies. So, following its advice, I didyarn remove rehype
, rebuilt my website, and got:If I understand correctly, before I was getting lucky because although
mdx-prism
wasn't installingrehype
for itself, it was able to traverse up thenode_modules/
tree and find therehype
that was installed for my website.So I think really all of the includes in
index.js
should be moved from dev to normal dependencies. I can submit a PR if you want.The text was updated successfully, but these errors were encountered: