Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing multipart/form-data parameters #38

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Fix missing multipart/form-data parameters #38

merged 1 commit into from
Dec 3, 2021

Conversation

AlfredoRamos
Copy link
Contributor

Fixes #37 introduced by #35

@AlfredoRamos AlfredoRamos mentioned this pull request Dec 3, 2021
Merged
j0k3r
j0k3r requested changes Dec 3, 2021
View reviewed changes
Copy link
Owner

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix proposal!
Could you just run php-ça-fixer to fix issue? Thanks

@AlfredoRamos
Copy link
Contributor Author

Mmm... now the tests that were passing, are now failing...

I'll fix it tomorrow when I have more free time to investigate.

j0k3r
j0k3r approved these changes Dec 3, 2021
View reviewed changes
Copy link
Owner

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I retrigger tests and there are ok now 🤷‍♂️
Thanks for the fix!

@j0k3r j0k3r merged commit 282e54f into j0k3r:master Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j0k3r j0k3r j0k3r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image upload POST request removes multipart/form-data parameters
2 participants
@AlfredoRamos @j0k3r