Fix PHP Error/Warnning #279
Conversation
|
Looks great, you can squash your commits 👍 |
girishpanchal30
force-pushed
the
master
branch
from
9221e1b
to
23aed1e
Compare
|
Thanks @girishpanchal30! |
| if (\count($currentConfig->find_string) !== \count($currentConfig->replace_string)) { | ||
| return $currentConfig; | ||
| } |
There was a problem hiding this comment.
This looks weird to me. Sohuld not we rather return $newConfig? And should not we check the variables from $newConfig? I would assume the $currentConfig has been already validated upon construction.
There was a problem hiding this comment.
You're right, I'll move that check in parseLines instead
| @@ -201,8 +201,8 @@ public function process(string $html, string $url, SiteConfig $siteConfig = null | |||
| $this->readability = $this->getReadability($html, $url, $parser, $this->siteConfig->tidy() && $smartTidy); | |||
| $tidied = $this->readability->tidied; | |||
|
|
|||
| $this->logger->info('Body size after Readability: {length}', ['length' => \strlen((string) $this->readability->dom->saveXML())]); | |||
| $this->logger->debug('Body after Readability', ['dom_saveXML' => $this->readability->dom->saveXML()]); | |||
| $this->logger->info('Body size after Readability: {length}', ['length' => \strlen((string) $this->readability->dom->saveXML($this->readability->dom->documentElement))]); | |||
There was a problem hiding this comment.
If https://www.php.net/manual/en/domdocument.savexml.php#44422 is correct, this would just save a page from unknown encoding as UTF-8. No idea how would it try to do that, possibly leading to some corruption.
There was a problem hiding this comment.
You're right, but that's not really a problem as it's inside the log, maybe the log will only be unreadable?
PHP Warning: array_combine(): Both parameters should have an equal number
PHP Warning: DOMDocument::saveXML(): unknown encoding
PHP Fatal error: Uncaught TypeError: Typed property Graby\Extractor\ContentExtractor::$title must be string or null
issue - #278