Improve readme with logo & credits #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
reviewed
Oct 24, 2019
|
|
||
| # Graby |
There was a problem hiding this comment.
I think the heading is still useful, especially when reading the README locally.
There was a problem hiding this comment.
FMPOV, the heading is now the logo, so the alt attribute acts as the heading when reading without readme being rendered.
There was a problem hiding this comment.
I am not sure it pops out very much when reading the document in text editor.
j0k3r
force-pushed
the
fix/readme-logo
branch
from
0e2ba04
to
f47b27c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poke @jtojnar.
What do you think?