Change the way to merge config for find & replace string #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`find_string` & `replace_string` had special case when merging them. But it failed when merging multiple times. Update it to a bit more complex solution to ensure `find_string` & `replace_string` aren't duplicated when merging config multiple times. We can't perform an `array_unique` on these values (looks like fabrizio got the point years ago) mostly because `replace_string` can have same values, example: ``` find_string: <amp-img replace_string: <img find_string: <other-img replace_string: <img ``` To fix that issue, we combine find & replace as key & value in one array, we merge them (so we can't have duplicates keys) and then rebuild find & replace string in the current config
j0k3r
force-pushed
the
fix-bad-merge-find-replace-string
branch
from
61b5586
to
9336ff5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_string&replace_stringhad special case when merging them.But it failed when merging multiple times some site config.
Update it to a bit more complex solution to ensure
find_string&replace_stringaren't duplicated when merging config multiple times.We can't perform an
array_uniqueon these values (looks like fabrizio got the point years ago) mostly becausereplace_stringcan have same values, example:To fix that issue, we combine find & replace as key & value in one array, we merge them (so we can't have duplicates keys) and then rebuild find & replace string in the current config.
@fivefilters, you might be interested by applying that fix on FullTextRSS I think.
Fix wallabag/wallabag#4025