Logger infos added for JsonLd parsing #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should update tests too |
|
Hmm, I'm kind of lost. I've just added logger infos. What do you want me to test? |
|
Some tests check the log output so you might need to update them. But first you should fix the undefined member access: |
Simounet
force-pushed
the
feat/jsonld-logger-infos
branch
from
cfab277
to
e2314b6
Compare
|
I fixed it. Sorry for that. |
j0k3r
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I added some info from the logger to get debug on JsonLd parsing.
Have a nice day.