Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework JsonLd extraction: ignore some objects and some names #196

Merged
merged 1 commit into from
Feb 13, 2019

Conversation

Kdecherf
Copy link
Collaborator

Ignore objects with type Organization, WebSite or Person. Also maintain
a list of values (only name) from these ignored objects to reject
similar values in other objects (e.g. a Periodical object with the name
of the WebSite).

Fixes wallabag/wallabag#3878

@coveralls
Copy link

coveralls commented Feb 11, 2019

Coverage Status

Coverage increased (+0.02%) to 97.781% when pulling 879ef69 on Kdecherf:jsonld-ignore into c9e85d2 on j0k3r:master.

Ignore objects with type Organization, WebSite or Person. Also maintain
a list of values (only name) from these ignored objects to reject
similar values in other objects (e.g. a Periodical object with the name
of the WebSite).

Fixes wallabag/wallabag#3878

Signed-off-by: Kevin Decherf <[email protected]>
@j0k3r j0k3r merged commit 6c1506f into j0k3r:master Feb 13, 2019
@Kdecherf Kdecherf deleted the jsonld-ignore branch March 8, 2019 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants