Handle "if_page_contains" for "next_page_link" #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`single_page_link` has priority over `next_page_link` when both are defined the site config file and `if_page_contains` rules are defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
single_page_linkhas priority overnext_page_linkwhen both are defined the site config file andif_page_containsrules are defined.Problem appear when you want to fetch the homepage of
rollingstone.comfor example (yeah bad idea anyway). The source contains thenext_page_linkdefined in the site config. But as graby doesn't handleif_page_containsfornext_page_linkit started to fetch endlessly all pages from rollingstone homepage. Gasp.Following #190