Bundle OmniStudio support in the logging framework #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @j-fischer - I don't think we've ever had the chance to meet/talk, but we're both logging nerds in the Salesforce ecosystem. I'm the creator of Nebula Logger, and I just added support for OmniStudio yesterday. I saw that you've provided OmniStudio support for a while, but it's not currently bundled into your package because you're using the Vlocity interfaces (in addition to
Callable
).From what I've seen, the Vlocity interfaces aren't necessary, you can use just the
Callable
interface. In Salesforce's docs, it says:By using just the
Callable
interface, the code can be deployed to any Salesforce org, even if it doesn't have a version of OmniStudio. So, I thought I'd submit a PR with the changes to make your OmniStudio support available out of the box in rflib.Changes made:
VlocityOpenInterface
interface & switched to only use theCallable
interfaceinvokeMethod()
, but it's nowprivate
- onlycall()
is exposedcall()
method (instead ofinvokeMethod()
), and adjusted a few asserts as needed (due to the difference in return values forcall()
andinvokeMethod()
)