Arrays are always generated with the same size #396
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It solves the #387 issue for arrays. I applied the same solution as @benas did in #391 for collections.
The change caused the
generatedObjectShouldBeAlwaysTheSameForTheSameSeed
to fail. I fixed it in the same way as in PR 391 which raised there some controversy. I extracted from the test the flow regarding arrays to a new test where I generate arrays using the same seed and then assert the equality of the generated arrays. I could adapt the original test by changing the expected array, but such a solution is not clean in my opinion. The expected array is a magic value and it doesn't manifest the test intention. It compares generated array against the magic value whereas the goal is (unless I'm mistaken) to assure that reusing the seed leads to generating the same results.