Fix #41: Handle large numbers safely in millify using BigInt #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The
millify
library throws a warning when the input value exceeds JavaScript’s safe integer range (-(2^53 - 1)
to(2^53 - 1)
), causing incorrect behavior when trying to format large numbers such as210000000000000000
.Changes:
safeMillify
function that:BigInt
.millify
for formatting.Note
I have replaced the default
millify
function withsafeMillify
, though it is exported as the same name. Should we consider exportingsafeMillify
seperately?