Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed tf.math.argmax for all backends #28347

Merged
merged 5 commits into from
Feb 20, 2024

Conversation

Sai-Suraj-27
Copy link
Contributor

@Sai-Suraj-27 Sai-Suraj-27 commented Feb 20, 2024

PR Description

Fixed tf.math.argmax for all the backends.

image

Fixed tf.math.argmin for the remaining tensorflow and numpy backends.

image

Related Issue

Closes #28343
Closes #28344
Closes #28345
Closes #28346
Closes #28348
Closes #28349
Closes #28350

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Feb 20, 2024
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. great stuff @Sai-Suraj-27 : )

@Ishticode Ishticode merged commit 1854ca1 into ivy-llc:main Feb 20, 2024
109 of 141 checks passed
@Sai-Suraj-27 Sai-Suraj-27 changed the title fix: Fixed tf.math.argmax for jax, torch, paddle, and tensorflow backends fix: Fixed tf.math.argmax for all backends Feb 20, 2024
Kacper-W-Kozdon pushed a commit to Kacper-W-Kozdon/ivy that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment