Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added true_divide_ to the to PyTorch frontend #21953

Merged
merged 6 commits into from
Aug 17, 2023
Merged

Added true_divide_ to the to PyTorch frontend #21953

merged 6 commits into from
Aug 17, 2023

Conversation

he11owthere
Copy link
Contributor

closes #21952

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@he11owthere
Copy link
Contributor Author

he11owthere commented Aug 15, 2023

@jieunboy0516, please remove "bfloat16" from the with_supported_dtypes decorator before running the tests until the issue with ivy.Array.repr method has been fixed as mentioned by Ved in #21447. Thank you! 🙂

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Aug 15, 2023
@jieunboy0516
Copy link
Contributor

Hi, thanks for your contribution to Ivy! Can you make sure the parameter rounding_mode is set to None too according to the doc? Thanks.

https://pytorch.org/docs/stable/generated/torch.true_divide.html#torch.true_divide

@he11owthere
Copy link
Contributor Author

Hi, thanks for your contribution to Ivy! Can you make sure the parameter rounding_mode is set to None too according to the doc? Thanks.

https://pytorch.org/docs/stable/generated/torch.true_divide.html#torch.true_divide

Yes, I made that sure. Thank you! 😊

@jieunboy0516 jieunboy0516 merged commit ca5c9aa into ivy-llc:main Aug 17, 2023
123 of 133 checks passed
sushmanthreddy pushed a commit to sushmanthreddy/ivy that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

true_divide_
3 participants