Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TS3.0 projectReferences #579

Merged
merged 3 commits into from
Jun 18, 2018

Conversation

rbuckton
Copy link
Contributor

Adds support for building projects using TS 3.0 project references.

@rbuckton
Copy link
Contributor Author

@ivogabe Can you take a look? Unfortunately, TypeScript itself can no longer use gulp-typescript in 'master' until minimal project reference support is added.

@rbuckton
Copy link
Contributor Author

Not certain what's causing the test failure, as it is passing on my machine.

@ivogabe
Copy link
Owner

ivogabe commented Jun 15, 2018

Thanks for the PR, will take a look at it this weekend. I’ll also look at the test failure.

@ivogabe
Copy link
Owner

ivogabe commented Jun 17, 2018

When I run the tests, I get the following diff with your baselines: 53823ab. The CI probably has the same errors, I'm not sure why it doesn't show that in the output though. Is that baseline correct? Or is this not intended?

Other than that, the changes are good and can be merged.

@ivogabe
Copy link
Owner

ivogabe commented Jun 17, 2018

(Could the difference in output for the test be caused by Windows versus Linux/Mac?)

@rbuckton
Copy link
Contributor Author

@ivogabe I found the issue and updated the PR.

@ivogabe ivogabe merged commit 95e9c2b into ivogabe:master Jun 18, 2018
@ivogabe
Copy link
Owner

ivogabe commented Jun 18, 2018

Thanks for the PR, released as 5.0.0-alpha.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants