Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the exclude property #145

Closed
ivogabe opened this issue Jun 4, 2015 · 2 comments
Closed

Support the exclude property #145

ivogabe opened this issue Jun 4, 2015 · 2 comments
Labels
Bug

Comments

@ivogabe
Copy link
Owner

ivogabe commented Jun 4, 2015

See microsoft/TypeScript#3188
@ivogabe ivogabe added the Bug label Jun 4, 2015
@ivogabe ivogabe closed this as completed in 7188e0f Jun 4, 2015
@jdiprizio
Copy link

Thanks for this but there are two issues with your implementation (as per the original referenced TypeScript pull request):

  • the property name is exclude and not excludes
  • it does not use glob patterns (unless I'm mistaken, your implementation requires values such as node_modules/** which are not supported by TypeScript's implementation)

ivogabe added a commit that referenced this issue Sep 6, 2015
@ivogabe
Rename excludes to exclude, support directory excludes
1f8f728 
See #145
@ivogabe
Copy link
Owner Author

ivogabe commented Sep 6, 2015

You're right about that, I've fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdiprizio @ivogabe