-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for the Base Model for VO-DML 1.1 #62
Open
pahjbo
wants to merge
42
commits into
master
Choose a base branch
from
base_update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds identifier types
because of pahjbo/vodsl#22 the conversion from the VODSL is incorrect - in practical terms this does not matter too much - however, Int Identifier is wrong for instance.
as this jar will always be a dependency on a real model, the persistence.xml just gets in the way of the one for the "target" data model.
# Conflicts: # models/ivoa/build.gradle.kts
# Conflicts: # tools/gradletooling/sample/src/test/java/org/ivoa/dm/notstccoords/CoordsModelTest.java
it should have specialized behaviour in future.
# Conflicts: # .gitignore # models/ivoa/build.gradle.kts
# Conflicts: # .gitignore
this is in reference to #37
these are a bit crude, as they are at intermediate stage in doing a better job of generating for primitives
abstract primitives are almost useless - cannot know their type
just lines up some dependencies
# Conflicts: # models/ivoa/build.gradle.kts # runtime/java/build.gradle.kts # tools/ChangeLog.md # tools/gradletooling/gradle-plugin/build.gradle.kts # tools/gradletooling/gradle-plugin/src/main/kotlin/net/ivoa/vodml/gradle/plugin/VodmlGradlePlugin.kt
in preparation for adding enhanced unit functionality/manipulation
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.