Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTypes in examples section. #6

Open
mcdittmar opened this issue Mar 17, 2023 · 0 comments
Open

UTypes in examples section. #6

mcdittmar opened this issue Mar 17, 2023 · 0 comments

Comments

@mcdittmar
Copy link
Collaborator

Section 3.5 of the document states that

"the UTYPEs all begin with the prefix "Spectrum.".

And illustrate with an example:

"UTYPEs such as 'Curation.Contact.Email' should be instantiated as 'Spectrum.Curation.Contact.Email'.

There are 2 example VOTables in Section 8.

  • The first appears to have completely ignored this requirement so that basically all of the UTYPEs in that example are invalid.
  • The second (SSA) example is much better, there are a couple GROUPs without the 'Spectrum.'. However, this model does not define UTYPEs for the objects, only leaves.. so this may be valid per the SSAP specification.

A sweep should be made to correct the example.

mcdittmar added a commit that referenced this issue Mar 12, 2024
* separate doc and diagrams

* rename main tex file, clean up Makefile

* step toward ivoatex Makefile

* rename files; step toward ivoatex.  no content change

* Update README.md

* rename and relocate schema

* switch to pdflatex; update diagrams to UML

* Create preview.xml

* Update README.md

* Rename preview.xml to preview.yml

* Update preview.yml

* Update preview.yml

* Update preview.yml

* Update preview.yml

* Update preview.yml

* Update preview.yml

* Update preview.yml

* add overview diagram; individual, not in doc

* add spectral order elements

* add spectral order elements

* add upper/lower limit elements

* correct case of order and relorder attributes

* fix document date

* Update README.md

add link to PDF-preview

* Update README.md

fix URL (oy!)

* Fix for Issue #6: bad utypes in example1

* Fix for Issue #5: ucd assigment for upper/lower limits

* Migrate to PR status

* Update to REC

---------

Co-authored-by: Laurent MICHEL <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant