-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tickets from gitlab #12
Conversation
ObjVisSAP.tex
Outdated
%%%%%%%%%%%%%%%%%%%% starts here %%%%%%%%%%%%%%%%%%%% | ||
\begin{table}[h] | ||
\centering | ||
\begin{tabular}{|l|l|} | ||
\hline | ||
\begin{lstlisting}[language=SQL] | ||
http://xmmvischeck.esac.esa.int:8080/objvissap/query? | ||
POS=10.68,41.27&T_MAX=59522 | ||
POS=10.68,41.27&T=59522/59532 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The T=
here should be TIME=
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are fully right. Thanks!
Corrected
@jd-au I corrected the typo you found. Could you please take a look to see if everything is OK to do the merging? Thanks! |
<PARAM name="INPUT:TIME" | ||
utype="Char.TimeAxis.Coverage.Bounds.Limits" | ||
datatype="float" | ||
unit="d" value="58171.45833/58321.958333"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have xtype="interval"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ObjVisSAP protocol does not have any xtype defined for any of its fields. I think this is because it is more based on previous S * AP protocols where xtype was not used (SIAP 1.0, SSAP, SLAP, etc)
I think xtype appeared during the TAP discussions (to allow the description of ADQL types) and it was only incorporated in a S * AP for SIAP 2.0
Most probably, only this field is affected but I have raised a different issue
#13
for a more complete review
If you agree, I would merge this one and deal the new issue in a different pull request after discussion with the rest of the authors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that sounds like a good approach.
No description provided.