Fix additional coordinate system information #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was duplicating information given in the sections DISTANCE and COORDSYS.
The aim of this change is to avoid confusion with the COORDSYS section speaking about the COORDSYS() function.
in `DISTANCE`, `CONTAINS` and `INTERSECTS`. The explanations about the deprecated parameter COOSYS have been rephrased for more clarity.
msdemlei
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following comments (5), (6) and (7) of @msdemlei in the ADQL-2.1 RFC page, here are few fixes about the usage of the coordinate system argument.
Basically:
Utility functions; it just duplicated what was said in sectionCOORDSYS,DISTANCE,POINT, ...COORDSYSintoCoordinate systemin order to avoid confusion with the section speaking about theCOORDSYSfunctionCoordinate systemand include explanations aboutDISTANCE,CONTAINSandINTERSECTSDISTANCE,CONTAINSandINTERSECTSabout automatic coordinates conversion ; reference the sectionCoordinate systeminstead