-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC corrections suggested by DAL WG #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a brief nitpick for the language lawyers. From my PoV, feel free to merge in whatever form (including a force-merge in case this review goes stale).
Thanks!
|
||
As in SQL-92, comments are supported in ADQL. A comment can be anywhere in the | ||
query. It starts with a double minus sign and ends with the end of line. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"anywhere in the query" is too strong a statement; in the SQL92 grammar, there's the separator nonterminal that we've (rightly) thrown out, so we can't refer to that. What about "A comment is syntactically legal wherever whitespace is legal (and can then stand in for that whitespace)"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing those.
No new comment for 2 weeks, I assume I can merge now. Thanks to all of you for your inputs :-) |
Le 31/10/2023 à 14:14, Grégory Mantelet a écrit :
No new comment for 2 weeks, I assume I can merge now. Thanks to all of
you for your inputs :-)
—
Reply to this email directly, view it on GitHub
<#100 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMP5LTC4DZ3O2QW577SZZRDYCD2U5AVCNFSM6AAAAAA54CE6MKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBXGE4TMNZZGM>.
You are receiving this because you are subscribed to this
thread.Message ID: ***@***.***>
Thanks to all. I expect loading a firts version of the Implementation
note by the beginning of interop
|
Here are some corrections suggested by the DAL WG: