Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC corrections suggested by DAL WG #100

Merged
merged 6 commits into from
Oct 31, 2023

Conversation

gmantele
Copy link
Collaborator

@gmantele gmantele commented Oct 11, 2023

Here are some corrections suggested by the DAL WG:

  • add section about comments in query
  • add a paragraph explaining how to escape a single quote in a string literal
  • reword intro of the section "Datatype functions" (about geometry constructors)
  • fix ADQL versions not allowing differing COOSYS arguments in the section "Coordinate System"
  • add explicit recommendation to use the EN for the Catalogue of UDF

Copy link
Contributor

@msdemlei msdemlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a brief nitpick for the language lawyers. From my PoV, feel free to merge in whatever form (including a force-merge in case this review goes stale).

Thanks!


As in SQL-92, comments are supported in ADQL. A comment can be anywhere in the
query. It starts with a double minus sign and ends with the end of line.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"anywhere in the query" is too strong a statement; in the SQL92 grammar, there's the separator nonterminal that we've (rightly) thrown out, so we can't refer to that. What about "A comment is syntactically legal wherever whitespace is legal (and can then stand in for that whitespace)"?

jd-au
jd-au previously approved these changes Oct 17, 2023
Copy link
Member

@jd-au jd-au left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing those.

@gmantele gmantele requested a review from jd-au October 18, 2023 10:50
@gmantele gmantele added the enhancement New feature or request label Oct 18, 2023
@gmantele gmantele added this to the 2.1 milestone Oct 18, 2023
@gmantele
Copy link
Collaborator Author

No new comment for 2 weeks, I assume I can merge now. Thanks to all of you for your inputs :-)

@gmantele gmantele merged commit 5e38cd3 into ivoa-std:master Oct 31, 2023
1 check passed
@Bonnarel
Copy link

Bonnarel commented Oct 31, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants