-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The response of windowlevel is very slow #34
Comments
Hi, thanks for your feedback. You are right, on some platforms/browsers, the w/l can be quite slow. The bigger the image, the slower too. |
I tested with the newest Chrome and Firefox on Win7. |
What do you consider a good response time? I am getting times in the range of about 400 ms for a rather big image (~5 MM Pixels) on my old desktop computer. I find these values acceptable. |
I test the response again. Chrome is faster than Firefox. The response on Chrome is fast. When I stop moving the mouse, the dicom viewer response immediately. However, the response on Firefox will take about 2-3 seconds. I think we can improve the response speed while mouse moving instead of mouse stopping on Chrome. When I change the windowlevel, I hope that I can adjust my moving by watching the response without mouse stopping. Thank you for you quick feedback:) |
I agree, Firefox is a bit slow... I put some notes on the different platforms on this wiki page: https://github.com/ivmartel/dwv/wiki/Platform-support |
I found that the response would be fast when I uncomment the function updatePlot. This function spends a lot of time. It will take about 2-3 seconds to change the windowlevel one times by Chrome. I found updatePlot spent a lot of CPU time by Chrome timeline. So I uncomment the function. After that, it only need 230ms to finish the change. |
added test. Removing listeners when the info layer is not displayed. Relates to #34.
Good point. I disabled the update of the plot when it is not displayed and I can see the difference under Firefox. I need to better use flot or find a faster library! |
Chrome's developer tools(Ctrl+Shift+I). Switch to the timeline tab and click the 'Record' button. You can watch the display time by this method. |
I hope this new release (v0.4) goes in the good direction... |
If I change windowlevel several times, the viewer won't immediately reponse.
I think the experience could be improved.
The text was updated successfully, but these errors were encountered: