fix

ivanmorozov333 · Jan 28, 2025 · 275bac4 · 275bac4
1 parent 7524918
commit 275bac4
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 21 deletions.
diff --git a/ydb/core/tx/columnshard/engines/scheme/column/info.cpp b/ydb/core/tx/columnshard/engines/scheme/column/info.cpp
@@ -3,22 +3,6 @@
 
 namespace NKikimr::NOlap {
 
-NArrow::NTransformation::ITransformer::TPtr TSimpleColumnInfo::GetSaveTransformer() const {
-    NArrow::NTransformation::ITransformer::TPtr transformer;
-    if (DictionaryEncoding) {
-        transformer = DictionaryEncoding->BuildEncoder();
-    }
-    return transformer;
-}
-
-NArrow::NTransformation::ITransformer::TPtr TSimpleColumnInfo::GetLoadTransformer() const {
-    NArrow::NTransformation::ITransformer::TPtr transformer;
-    if (DictionaryEncoding) {
-        transformer = DictionaryEncoding->BuildDecoder();
-    }
-    return transformer;
-}
-
 TConclusionStatus TSimpleColumnInfo::DeserializeFromProto(const NKikimrSchemeOp::TOlapColumnDescription& columnInfo) {
     AFL_VERIFY(columnInfo.GetId() == ColumnId);
     if (columnInfo.HasSerializer()) {

diff --git a/ydb/core/tx/columnshard/engines/scheme/column/info.h b/ydb/core/tx/columnshard/engines/scheme/column/info.h
@@ -30,19 +30,16 @@ class TSimpleColumnInfo {
     YDB_READONLY(bool, IsSorted, false);
     YDB_READONLY(bool, IsNullable, false);
     YDB_READONLY_DEF(TColumnDefaultScalarValue, DefaultValue);
-    std::optional<NArrow::NDictionary::TEncodingSettings> DictionaryEncoding;
     std::shared_ptr<TColumnLoader> Loader;
-    NArrow::NTransformation::ITransformer::TPtr GetLoadTransformer() const;
 
 public:
     TSimpleColumnInfo(const ui32 columnId, const std::shared_ptr<arrow::Field>& arrowField,
         const NArrow::NSerialization::TSerializerContainer& serializer, const bool needMinMax, const bool isSorted, const bool isNullable,
         const std::shared_ptr<arrow::Scalar>& defaultValue, const std::optional<ui32>& pkColumnIndex);
 
     TColumnSaver GetColumnSaver() const {
-        NArrow::NTransformation::ITransformer::TPtr transformer = GetSaveTransformer();
         AFL_VERIFY(Serializer);
-        return TColumnSaver(transformer, Serializer);
+        return TColumnSaver(Serializer);
     }
 
     std::vector<std::shared_ptr<IPortionDataChunk>> ActualizeColumnData(
@@ -56,7 +53,6 @@ class TSimpleColumnInfo {
         return sb;
     }
 
-    NArrow::NTransformation::ITransformer::TPtr GetSaveTransformer() const;
     TConclusionStatus DeserializeFromProto(const NKikimrSchemeOp::TOlapColumnDescription& columnInfo);
 
     const std::shared_ptr<TColumnLoader>& GetLoader() const {