Adde from_date and to_date options to limit the processed files #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivandokov
requested changes
Jul 12, 2023
phockup.py
Outdated
| @@ -296,6 +296,28 @@ def parse_args(args=sys.argv[1:]): | |||
| files by an additional level after sorting by date. | |||
| """ | |||
| ) | |||
|
|
|||
| parser.add_argument( | |||
| '--from_date', | |||
phockup.py
Outdated
| ) | ||
|
|
||
| parser.add_argument( | ||
| '--to_date', |
src/phockup.py
Outdated
| if type(file_date) is dict: | ||
| file_date = file_date["date"] | ||
| if self.from_date is not None and file_date < self.from_date: | ||
| progress = f"{progress} => {filename} skipped: date {file_date} is older than from_date {self.from_date}" |
There was a problem hiding this comment.
Please replace _ with - for option name and maybe add -- to the option name (--from-date)
…he arguments names
unapproachable
pushed a commit
to unapproachable/phockup
that referenced
this pull request
Sep 23, 2024
…dokov#202) * Added from_date and to_date options to limit the processed files * Removed a leftover debug print * Added info for this feature in the readme. Replaced "_" with "-" in the arguments names --------- Co-authored-by: Marco Dondero <[email protected]> Co-authored-by: Ivan Dokov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
from_dateandto_datecommand line options to limit the file processing based on the calculated data. Files with unknown date are unfiltered.This is useful to me because I have a sync folder where the phones keep dumping the data so deleted pictures will be recreated.
I use phockup to copy the pics to a nice structure and then select the ones that I want to keep, so reprocessing all the source folder would replace the photos that I deleted.