Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing: Deprecate old channel API routes #5045

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

SamantazFox
Copy link
Member

Deprecate the following routes:

  • /api/v1/channels/videos/:ucid
  • /api/v1/channels/latest/:ucid
  • /api/v1/channels/playlists/:ucid
  • /api/v1/channels/community/:ucid
  • /api/v1/channels/search/:ucid

in favor of:

  • /api/v1/channels/:ucid/videos
  • /api/v1/channels/:ucid/latest
  • /api/v1/channels/:ucid/playlists
  • /api/v1/channels/:ucid/community
  • /api/v1/channels/:ucid/search

@SamantazFox SamantazFox requested a review from a team as a code owner October 31, 2024 10:56
@SamantazFox SamantazFox requested review from unixfox and removed request for a team October 31, 2024 10:56
@SamantazFox SamantazFox added the need-code-review A crystal developper need to check if the code is correct. label Oct 31, 2024
@Fijxu
Copy link
Contributor

Fijxu commented Nov 1, 2024

Why remove them tho? The "deprecated" api routes won't be replaced by another routes so deleting them will just force everyone to change the route in their program.

This is to follow the same syntax that YouTube channels have right?

@absidue
Copy link
Contributor

absidue commented Nov 1, 2024

@Fijxu This doesn't add any new routes, it just removes undocumented routes. The old routes were removed from the documentation in this commit on the 14th of January 2023 iv-org/documentation@dca9398, that is almost 2 years ago, which should be more than enough time for people to switch to the correct endpoints, especially considering that the "new" endpoints have existed for even longer than that.

@SamantazFox SamantazFox added need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something in-testing This feature has been deployed and is being tested ready and removed need-code-review A crystal developper need to check if the code is correct. need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something in-testing This feature has been deployed and is being tested labels Nov 8, 2024
@SamantazFox SamantazFox merged commit bc86fb8 into iv-org:master Nov 10, 2024
8 of 9 checks passed
@SamantazFox SamantazFox deleted the deprecate-channel-routes branch November 10, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants