SigHelper: Reconnect to signature helper #4991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fijxu <[email protected]>
SamantazFox
approved these changes
Oct 9, 2024
|
Thanks for your contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4926
I have been using it for more than 3 weeks on my instance and it works really well.
This works if
inv_sig_helpercrashes and restarts itself (via systemd or docker restart policy) but it will not work ifinv_sig_helperhangs and it doesn't reply to invidious (but this is an issue withinv_sig_helperand not Invidious).What I do to try to reconnect to an alive
inv_sig_helperinstance is to use replicas of it and balance them with HAProxy so invidious will be always able to reach an aliveinv_sig_helper, but that's another topic.