Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use WEB_CREATOR when po_token with WEB_EMBED as a fallback #4928

Merged
merged 2 commits into from
Sep 19, 2024
Merged

use WEB_CREATOR when po_token with WEB_EMBED as a fallback #4928

merged 2 commits into from
Sep 19, 2024

Conversation

unixfox
Copy link
Member

@unixfox unixfox commented Sep 19, 2024

This is a continuation of the work done in #4923

  • This uses WEB_CREATOR client for fetching the streams data when po_token is configured. Thanks @rustynail1984 for the notification
  • WEB_EMBEDDED_PLAYER is configured as a fallback for po_token in case WEB_CREATOR doesn't work anymore
  • Since neither WEB_CREATOR nor WEB_EMBEDDED_PLAYER returns microformat data, I have configured so Invidious does not crash if it doesn't find it anymore. This means that we will be missing some info until we switch the retrieval of this info from the next endpoint.
    But this is better than nothing that works.
  • TvHtml5ScreenEmbed won't be used when po_token is configured since it doesn't work with it.

@unixfox unixfox requested a review from a team as a code owner September 19, 2024 21:29
@unixfox unixfox requested review from syeopite and removed request for a team September 19, 2024 21:29
@unixfox unixfox requested a review from SamantazFox September 19, 2024 21:36
@unixfox unixfox merged commit d9df90b into iv-org:master Sep 19, 2024
8 checks passed
@unixfox unixfox deleted the fixpotoken2 branch September 19, 2024 22:19
@rustynail1984
Copy link

Found the latest verion in YouTube Studio.

clientName:  62 // corresponds to WEB_CREATOR
clientVersion:  "1.20240918.03.00"

This was referenced Sep 19, 2024
Open
Merged
unixfox added a commit to unixfox/YouTube.js that referenced this pull request Sep 19, 2024
@unixfox
update to latest version WEB_CREATOR iv-org/invidious#4928 (comment)
f63a8b1
This was referenced Sep 19, 2024
Open
Merged
LuanRT pushed a commit to LuanRT/YouTube.js that referenced this pull request Sep 20, 2024
@unixfox
feat: Add WEB_CREATOR client (#757)
dd7f5cf 
* feat: Add WEB_CREATOR client

* update to latest version WEB_CREATOR iv-org/invidious#4928 (comment)
@iBicha iBicha mentioned this pull request Sep 22, 2024
Closed
Fijxu added a commit to Fijxu/invidious that referenced this pull request Oct 9, 2024
@Fijxu
Revert "use WEB_CREATOR when po_token with WEB_EMBED as a fallback (i…
0597bd9 
…v-org#4928)"

This reverts commit d9df90b.
This was referenced Oct 10, 2024
Closed
Closed
mooleshacat added a commit to catspeed-cc/invidious that referenced this pull request Oct 15, 2024
@mooleshacat
Revert "use WEB_CREATOR when po_token with WEB_EMBED as a fallback (i…
07fe50b 
…v-org#4928)"

This reverts commit d9df90b.
mooleshacat added a commit to catspeed-cc/invidious that referenced this pull request Oct 15, 2024
@mooleshacat
Revert "use WEB_CREATOR when po_token with WEB_EMBED as a fallback (i…
aac73c1 
…v-org#4928)"

This reverts commit d9df90b.
lumpsoid pushed a commit to lumpsoid/invidious that referenced this pull request Nov 7, 2024
@unixfox @syeopite
use WEB_CREATOR when po_token with WEB_EMBED as a fallback (iv-org#4928)
6dc4125 
* use WEB_CREATOR when po_token with WEB_EMBEDDED_PLAYER as a fallback

* remove unrelated comment

Co-authored-by: syeopite <[email protected]>

---------

Co-authored-by: syeopite <[email protected]>
acheong08 pushed a commit to acheong08/invidious that referenced this pull request Nov 8, 2024
@Fijxu
Revert "use WEB_CREATOR when po_token with WEB_EMBED as a fallback (i…
cf6c3a7 
…v-org#4928)"

This reverts commit d9df90b.
mooleshacat added a commit to catspeed-cc/invidious that referenced this pull request Nov 9, 2024
@mooleshacat
Revert "use WEB_CREATOR when po_token with WEB_EMBED as a fallback (i…
05f932b 
…v-org#4928)"

This reverts commit d9df90b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syeopite syeopite syeopite approved these changes

@SamantazFox SamantazFox Awaiting requested review from SamantazFox

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@unixfox @rustynail1984 @syeopite