Ameba: Fix Lint/UselessAssign #4795
Conversation
| @@ -232,7 +232,7 @@ def fetch_channel(ucid, pull_all_videos : Bool) | |||
| id: video_id, | |||
| title: title, | |||
| published: published, | |||
| updated: Time.utc, | |||
| updated: updated, | |||
There was a problem hiding this comment.
I'm not too sure if this should be using the current time Time.utc or the parsed updated time
There was a problem hiding this comment.
I think it's supposed to report the time when the channel content was fetched by the background job. That's especially useful for channels that don't post often, when the last update is for a very old video.
There was a problem hiding this comment.
In that case should there be a new attribute that reports when the video was updated on YouTube's side? Or should we just remove the logic that parses the updated time?
invidious/src/invidious/channels/channels.cr
Lines 208 to 210 in fad0a4f
There was a problem hiding this comment.
Okay, my bad. All that time I though we were talking about InvidiousChannel.updated while you want to change ChannelVideo.updated.
My previous message applies to the former, and your fix in indeed welcome in the latter case :)
|
Thank you! |
No description provided.