Rewrite transcript logic to be more generic #4747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The transcript logic in Invidious was written specifically as a workaround for captions, and not transcripts as a feature. This commit genericises the logic a bit as so it can be used for implementing transcripts within Invidious' API and UI as well. The most notable change is the added parsing of section headings when it was previously skipped over in favor of regular lines.
syeopite
force-pushed
the
improve-transcripts-logic
branch
from
42e64ca to
0224162
Compare
SamantazFox
approved these changes
Jun 15, 2024
SamantazFox
added
need-testing
|
Works well, both captions and storyboards have no issues. |
SamantazFox
added
ready
and removed
in-testing
|
Thanks for your work ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transcript logic in Invidious was written specifically as a workaround for captions, and not transcripts as a feature.
This PR genericises the logic as so it can be used for actually implementing transcripts within Invidious' as well.
The most notable change is the added parsing of section headings when it was previously skipped over in favor of regular lines.
The changes in
src/invidious/videos/transcript.crshould be reviewed as more of a rewrite than just changes.